Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork149
Get rid of @string/@int for polyvars#770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
MoOx left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome work !
Do you think we could do something in PlatformColor for Android ? (I can handle it, I just want your opinion on this inglorious code xD
cknitt commentedOct 5, 2022
I have never used the Compare to TypeScript which just has this:https://github.com/DefinitelyTyped/DefinitelyTyped/blob/16db88356a79c458dbe5d88d9706aadec1d20db5/types/react-native/index.d.ts#L6041 I don't quite understand why one can pass an array of color names, what is that used for? |
MoOx commentedOct 5, 2022
Yeah that's clearly some copy paste here... And why an array ? Because if you pass more than one string value to the PlatformColor function, it will treat the first value as the default and the rest as fallback depending on their availability (make more sense for "user" values, with system fallbacks). I will update PlatformColor later then. |
cknitt commentedOct 5, 2022
@MoOx Ah, but if you can define a type now with |
MoOx commentedOct 6, 2022
Exactly. |
Resurrected#767.
Merge for ReScript 10 release.