Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork149
Get rid of @string/@int for polyvars#767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
MoOx left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome ! Thanks for spending time on this!
cknitt commentedAug 10, 2022
Just noticed I had forgotten the ~pointerEvents:pointerEvents=?, in a few places. Updated the PR. |
MoOx commentedAug 18, 2022
@cknitt Could you reopen this PR (create a new one yourself so you get proper credit) ?https://github.com/rescript-react-native/rescript-react-native/compare/main...simplify-polyvars?expand=1 |
cknitt commentedAug 18, 2022
Done, thanks! |
Closes#748.
These are breaking changes, but I think that's ok - more breaking changes likely to come with#766.