Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork149
reason-react-native: add example for ScrollView scrollTo method#577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
MoOx commentedAug 23, 2019
I used a switch for the example. Btw, I noticed that scrollTo have scrollToParams & that scrollToEndWithOptions have scrollToEndOptions. What do you think about normalising naming with Params or Options (& same for similar places?). @cknitt@sgny We could normalize & deprecate with warnings & remove deprecating warning in next major release? |
cknitt commentedAug 23, 2019
I think I used the different names on purpose. In the case of Not sure if this is consistent across the code though... |
Uh oh!
There was an error while loading.Please reload this page.
MoOx commentedAug 26, 2019
@cknitt I just find confusing the 2 namings. I get the idea. @sgny any comment? |
cknitt commentedAug 27, 2019
I am open to changing these method args from "params" to "options". Callback params like |
sgny commentedAug 27, 2019
I think the function name should remain |
cknitt commentedAug 27, 2019
I find I'd expect |
MoOx commentedAug 28, 2019
I would go for just ditching one & keep only the other for simplicity. |
cknitt commentedAug 28, 2019
If we want to unify this, I am for "Options" everywhere. |
sgny commentedAug 28, 2019
How about instead of |
totally wip but better than nothing?