Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add documentation for StyleSheet API#520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
MoOx merged 1 commit intorescript-react-native:masterfromsgny:stylesheetdoc
May 31, 2019

Conversation

@sgny
Copy link
Collaborator

Also added the relevant link toStyle.md

@sgnysgnyforce-pushed thestylesheetdoc branch 2 times, most recently from6b444c5 to1a788aeCompareMay 31, 2019 00:14
@sgnysgny requested a review fromMoOxMay 31, 2019 01:54
@sgnysgnyforce-pushed thestylesheetdoc branch 2 times, most recently from553ab75 toab1f95fCompareMay 31, 2019 02:23
cknitt
cknitt previously approved these changesMay 31, 2019
###`flatten`

Takes an array of styles (of type`Style.t`) and returns a single style (also of
type`Style.t`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe add a comment that using styles created withStyle.array inStyleSheet.create will lead to a runtime error, soStyleSheet.flattenmust be used in that case. (Style.array is fine for passing styles to component props though.)

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added such comments


```reason
create: Js.t('a) => Js.t('a)
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perhaps we revisit this issue later, but I don't think there is a way to excludearray(Style.t) without a lot of pain elsewhere.

@MoOxMoOx merged commit69a83fb intorescript-react-native:masterMay 31, 2019
@MoOx
Copy link
Member

👍

@sgnysgny deleted the stylesheetdoc branchJune 9, 2019 12:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@MoOxMoOxMoOx approved these changes

@cknittcknittcknitt left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sgny@MoOx@cknitt

[8]ページ先頭

©2009-2025 Movatter.jp