Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add markdown code block syntax highlight support#97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zth merged 15 commits intorescript-lang:masterfromwangbinyq:markdown
Jul 25, 2022

Conversation

@wangbinyq
Copy link
Contributor

No description provided.

@wangbinyqwangbinyq changed the titleadd markdown code block syntax highlight supportAdd markdown code block syntax highlight supportMar 26, 2021
@chenglou
Copy link
Member

Hey, thanks! Though is this the idiomatic way of doing it? It seems typescript's grammar repo doesn't have such thing?

@wangbinyq
Copy link
ContributorAuthor

I rewrite the file from thevscode-reasonml repo, just some minor changes.

@fhammerschmidt
Copy link
Member

@zth can we get semantic highlighting in markdown blocks as well?

@zth
Copy link
Member

zth commentedJul 13, 2022

@fhammerschmidt I'm not sure. Does TS do it?

@aspeddro
Copy link
Contributor

I was looking for how vscode apply syntax highlighting in markdown. It doesn't use semantic highlighting just TexMate grammar.

Here are supported languages.

@fhammerschmidt
Copy link
Member

Having at least a bit of highlighting would already be nice.
Currently it is just all the same color.

image

@zth
Copy link
Member

zth commentedJul 24, 2022

I'm thinking we should merge this as is. I agree that some highlighting is better than none. Ok with you@cristianoc ?

Side note: There's more interesting things we can do eventually to better support md, like formatting code inside of ReScript md blocks.

cristianoc reacted with thumbs up emoji

cknittand others added13 commitsJuly 25, 2022 13:24
…ng from the language client. This just ensures that the server tells the client that sending codeLens requests is fine. Next we'll implement the actual functionality that resolves the code leneses.
…rinter towards printing function types for code lenses on one line
@zthzth merged commitd180824 intorescript-lang:masterJul 25, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wangbinyq@chenglou@fhammerschmidt@zth@aspeddro@cknitt

[8]ページ先頭

©2009-2025 Movatter.jp