- Notifications
You must be signed in to change notification settings - Fork61
null check reanalyze output#456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| json=JSON.parse(data); | ||
| }catch(e){ | ||
| window.showErrorMessage( | ||
| `Something went wrong parsing the json output of reanalyze: '${e}'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you add a bit more. How about encouraging reporting the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll add this in a separate PR when I've figured out what makes sense to tell the user here.
So we don't accidentally crash the extension if we don't get proper json from reanalyze. It happens locally for me, which is another issue I'll investigate. But, this will at least ensure we don't crash.