- Notifications
You must be signed in to change notification settings - Fork61
ensure updated config is synced on use of restart command#438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…up a few unused things
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks great.
The only thing that comes to mind, is how to make it completely explicit that the code that followscreateLanguageClient is the global state. (which is preserved on restart).
In fact, there's one other small bit of global state: which is followed by a bunch of commented out code. Then the |
Initial read configuration was never refreshed as the restart command runs, which means you'd always get potentially stale initial config after a restart.
Also clean up a few init things that I suspect has never been cleaned up after the initial adaption of the LS client example.