Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

sharing config between client and server#432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cristianoc merged 5 commits intomasterfromshared-configuration
May 30, 2022

Conversation

@zth
Copy link
Member

@zthzth commentedMay 28, 2022
edited
Loading

Fixes#23

This introduces configuration in the extension, periodically synced to the language server for use. We'll probably need to revisit this if we get more intricate configuration needs later on, but for now this is simple enough and will do for the cases we currently have.

@zthzth requested a review fromcristianocMay 29, 2022 16:45
Copy link
Collaborator

@cristianoccristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

How about adding the config to theexample-project as an example.
Also, should the README be updated.

@zth
Copy link
MemberAuthor

zth commentedMay 30, 2022

Updated the readme. Can't set up the configuration in the example project though, because VSCode doesn't save settings in the repo by default.

@zthzth requested a review fromcristianocMay 30, 2022 06:07
@cristianoccristianoc merged commita3f549d intomasterMay 30, 2022
@cristianoc
Copy link
Collaborator

Thanks! Merging.

@cristianoccristianoc deleted the shared-configuration branchMay 30, 2022 06:55
@cristianoc
Copy link
Collaborator

Nit: does not look like changing the setting and restarting the server picks them up.
Reloading the window does.
At least in debug mode. Haven't tried if it's the same when installing the .vsix file

@zth
Copy link
MemberAuthor

zth commentedMay 30, 2022

You mean when restarting via the restart command recently added?

@cristianoc
Copy link
Collaborator

You mean when restarting via the restart command recently added?

yes

@cristianoc
Copy link
Collaborator

Or I guess the more general question is: why polling. If one needs to restart anyway.
Maybe having to restart is not bad, and one can make everything simpler and remove the polling logic.

@zth
Copy link
MemberAuthor

zth commentedMay 30, 2022

Hmm, I don't need to restart anything, polling works fine for me as I tested. How are you testing it?

@cristianoc
Copy link
Collaborator

What I've tried is: change the setting, then ask the server to restart.

@cristianoc
Copy link
Collaborator

Don't know what else to test without restarting the entire editor.

@zth
Copy link
MemberAuthor

zth commentedMay 30, 2022

Ahh, I think I know the issue. I'll fix it.

cristianoc reacted with thumbs up emoji

@zth
Copy link
MemberAuthor

zth commentedMay 30, 2022

Done here:#438

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cristianoccristianocAwaiting requested review from cristianoc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prevent the "Start a build for this project to get the freshest data?" notification from spamming

3 participants

@zth@cristianoc

[8]ページ先頭

©2009-2025 Movatter.jp