Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Dce touchups#366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
cristianoc merged 2 commits intorescript-lang:masterfromzth:dce-touchups
Mar 9, 2022
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletionsclient/src/commands/dead_code_analysis.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -132,15 +132,21 @@ let dceTextToDiagnostics = (
}

let issueLocationRange = new Range(startPos, endPos);
let diagnosticText = text.trim();

let diagnostic = new Diagnostic(
issueLocationRange,
text.trim(),
diagnosticText,
DiagnosticSeverity.Warning
);

// This will render the part of the code as unused
diagnostic.tags = [DiagnosticTag.Unnecessary];
// Everything reanalyze reports is about dead code, except for redundant
// optional arguments. This will ensure that everything but reduntant
// optional arguments is highlighted as unecessary/unused code in the
// editor.
if (!diagnosticText.toLowerCase().startsWith("optional argument")) {
diagnostic.tags = [DiagnosticTag.Unnecessary];
}

if (diagnosticsMap.has(processedFileInfo.filePath)) {
diagnosticsMap.get(processedFileInfo.filePath).push(diagnostic);
Expand Down
4 changes: 4 additions & 0 deletionspackage.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,6 +48,10 @@
{
"command": "rescript-vscode.start_dead_code_analysis",
"title": "ReScript: Start dead code analysis."
},
{
"command": "rescript-vscode.stop_dead_code_analysis",
"title": "ReScript: Stop dead code analysis."
}
],
"menus": {
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp