- Notifications
You must be signed in to change notification settings - Fork61
Implement our own JSON schema validation to use the correct build-schema.json for the installed compiler version#1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
1181d4e toc4295fcComparewill try a different approach (the same as TS LSP) |
c4295fc to525785fCompare@codex review |
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
 Can we scope this to node we are currently in? |
ab9936e to30ea575Compare@nojaf feel free to test again. |
@codex review |
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
I still see this thing first try: Inside empty quotes, the completion of editor adds an additional quote: |
Of course it only works in the jsx property and not in the more advanced cases, adding proper tests now. |
Fixes#1110