Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Playground toggles for jsx preserve mode and experimental features#1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fhammerschmidt
Copy link
Member

image

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pagesbot commentedSep 9, 2025•
edited
Loading

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit:73f0e14
Status: ✅  Deploy successful!
Preview URL:https://8809f996.rescript-lang.pages.dev
Branch Preview URL:https://playground-toggles-for-jsx-p.rescript-lang.pages.dev

View logs

Copy link
Member

@tsnobiptsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks good to me but for some reason I can't test it in the preview url, it errors with

TypeError: e.setExperimentalFeatures is not a function

@fhammerschmidt
Copy link
MemberAuthor

@tsnobip: I added a check for the playground apiVersion of the compiler bundle to prevent that error. As the playground compiler is only deployed with a new compiler version you'll have to wait until Friday to test this (or check it out locally).

tsnobip reacted with thumbs up emoji

Copy link
Member

@tsnobiptsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ok looks good to me now!

@fhammerschmidtfhammerschmidt merged commit0121332 intomasterSep 10, 2025
2 checks passed
@fhammerschmidtfhammerschmidt deleted the playground-toggles-for-jsx-preserve-and-experimental-features branchSeptember 10, 2025 17:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zthzthzth approved these changes

@tsnobiptsnobiptsnobip approved these changes

@nojafnojafnojaf approved these changes

@cknittcknittAwaiting requested review from cknitt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fhammerschmidt@zth@tsnobip@nojaf
[8]ページ先頭
©2009-2025 Movatter.jp