Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork254
Draft: let? blog post#1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cloudflare-workers-and-pagesbot commentedAug 27, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Deploying rescript-lang-org with |
| Latest commit: | 3a6e3e8 |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cc8f0371.rescript-lang.pages.dev |
| Branch Preview URL: | https://roadmap-let-unwrap.rescript-lang.pages.dev |
9bfb0c6 to68931f9CompareAssistant:
looks spot on to me |
Seems legit, except the last suggestion might be too much |
Btw |
68931f9 to156ad3cCompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| ->Result.flatMapOkAsync(decodedUser => ensureUserActive(decodedUser)) | ||
| ``` | ||
| **Note**: `Result.flatMapOkAsync` among some other async result helper functions are brand new in ReScript 12 as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks good and I think it’s ready to go.
One feeling I still get is that it reads like a new idea we haven't really tested in our codebase. I'm not sure if that's an issue or worth mentioning, but it's hard to tell whether this will be game-changing or not.
7c30336 to3a6e3e8Compare
Uh oh!
There was an error while loading.Please reload this page.
Closes#1086