- Notifications
You must be signed in to change notification settings - Fork471
Reduce logs#7971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Reduce logs#7971
Conversation
pkg-pr-newbot commentedOct 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
rescript@rescript/darwin-arm64@rescript/darwin-x64@rescript/linux-arm64@rescript/linux-x64@rescript/runtime@rescript/win32-x64commit: |
@jfrolich Emoji definitions for the now unused steps can be removed. Output for clean does not look optimal: |
Now it says (so either there is a space too much, or the number of files that were cleaned is missing) |
CHANGELOG.md Outdated
| - Rewatch: plain output when not running in tty.https://github.com/rescript-lang/rescript/pull/7970 | ||
| - Streamline rewatch help texts.https://github.com/rescript-lang/rescript/pull/7973 | ||
| - Rewatch: Reduced build progress output from 7 steps to 3 for cleaner, less verbose logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is missing the link to the issue.
Other than that, the PR looks good to me now. Thanks@jfrolich!
@fhammerschmidt Please merge and add the link when you build rc.3 tonight.
Can't merge it: |
cd6bc43 intomasterUh oh!
There was an error while loading.Please reload this page.
No description provided.