Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add --warn-error to Rewatch#7916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nojaf merged 10 commits intorescript-lang:masterfromnojaf:warn-error
Sep 26, 2025
Merged

Conversation

@nojaf
Copy link
Member

Fixes#7718

namenu reacted with thumbs up emoji
@pkg-pr-new
Copy link

pkg-pr-newbot commentedSep 22, 2025
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7916

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7916

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7916

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7916

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7916

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7916

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7916

commit:aefd238

@nojaf
Copy link
MemberAuthor

@cknitt you can already try this out.
Note that, as with the other commands, we now take two dashes--warn-error

@nojafnojaf marked this pull request as ready for reviewSeptember 22, 2025 11:16
@fhammerschmidt
Copy link
Member

Should we have-warn-error with one dash as well but immediately mark it as deprecated, like we have with-w?

@nojaf
Copy link
MemberAuthor

Should we have-warn-error with one dash as well but immediately mark it as deprecated, like we have with-w?

I'm against this idea. These hacks aren't worth it to me. It's a major version; adding a single dash is not the end of the world. Is there any evidence this is a widely used feature? For free software, I think it's a small price to pay.

@cknitt
Copy link
Member

@nojaf Thanks! Just tested, and works great. 🎉

@nojafnojaf added the build labelSep 26, 2025
@cknitt
Copy link
Member

@codex review

Copy link

@chatgpt-codex-connectorchatgpt-codex-connectorbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

@nojafnojaf requested a review fromCopilotSeptember 26, 2025 12:48
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds support for a--warn-error command-line flag to thebuild andwatch commands in Rewatch, allowing users to override warning configurations fromrescript.json. The flag follows the same precedence behavior as the legacy bsb build system.

  • Adds--warn-error CLI flag to bothbuild andwatch commands
  • Implements warning override logic that takes precedence overrescript.json configuration
  • Threads the warning parameter through the entire build system from CLI to compiler argument generation
  • Includes comprehensive test coverage and integration tests

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
rewatch/src/cli.rsAdds--warn-error field toBuildArgs andWatchArgs structs
rewatch/src/main.rsPasses the warn_error parameter to build and watch functions
rewatch/src/watcher.rsUpdates watcher to accept and thread the warn_error parameter
rewatch/src/config.rsImplements warning override logic and adds comprehensive unit tests
rewatch/src/build/Updates build system components to handle the new BuildCommandState wrapper
rewatch/tests/compiler-args.shAdds integration test to verify warning flags appear in both parser and compiler args
rewatch/testrepo/packages/namespace-casing/rescript.jsonAdds test configuration with warning settings

Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.

@nojafnojafenabled auto-merge (squash)September 26, 2025 13:16
@nojafnojaf merged commitc0aaede intorescript-lang:masterSep 26, 2025
25 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cknittcknittcknitt left review comments

Copilot code reviewCopilotCopilot left review comments

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

@jfrolichjfrolichjfrolich approved these changes

@rolandpeelenrolandpeelenAwaiting requested review from rolandpeelen

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rewatch: no way to override warnings as errors on command line

4 participants

@nojaf@fhammerschmidt@cknitt@jfrolich

[8]ページ先頭

©2009-2025 Movatter.jp