Open in StackBlitz

npm i https://pkg.pr.new/rescript-lang/rescript@7881

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7881

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7881

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7881

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7881

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7881

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7881

commit:ea0573f

@htoooth Thank you for your contribution! 👍

Instead of two bindings per function like

@sendexternalgetInt16: (t,int)=>int="getInt16"@sendexternalgetInt16LittleEndian: (t,int, @as(1)_)=>int="getInt16"

could you do single bindings like

@sendexternalgetInt16: (t,int, ~littleEndian:bool=?)=>int="getInt16"

please?

(Bonus points for adding doc strings with tests/code examples 🙂.)

@cknitt

1. I did it this way because I saw that's how it was done in the previous v11.
2. The idea of encapsulating polymorphic functions mentioned in the document is also to encapsulate for different situations.
3. This makes it easier to migrate old code.

By the way, I also initially thought of adding a parameter like your said@cknitt

Where to add tests and documentation? I couldn't find the previous documents and test cases

Using@as(1) _ here is neat btw

I did it this way because I saw that's how it was done in the previous v11.

In previous ReScript versions, the approach with the optional argument was not really ergonomic because a trailing unit argument was required.

Now that it has become feasible, we have moved to single bindings in the stdlib where possible, as this is much clearer to JS devs, basically resulting in a 1:1 correspondence with the JS APIs as documented on MDN.

E.g.Float.toString with optional parameterradix, deprecatingFloat.toStringWithRadix. There are many more such examples in the new stdlib.

Therefore, also theDataView bindings should follow suit.

Docstrings are in a corresponding .resi file and contain examples that are automatically verified as test assertions during the CI build.

Example:

@cknitt I have made the revisions and added the doc.

@cknitt

CI in Windows is passed, but others are not.
I ran 'make format', but nothing changed.
Can you help me?

@cknitt I have passed the CI

@htoooth Looks great now! One last thing - could you add a CHANGELOG entry, please?

@htoooth Looks great now! One last thing - could you add a CHANGELOG entry, please?

done