You signed in with another tab or window.Reload to refresh your session.You signed out in another tab or window.Reload to refresh your session.You switched accounts on another tab or window.Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This PR implements automatic wrapping of string literals in JSX children withJsx.string() calls, eliminating the need for manual wrapping.
Problem
Currently, string literals in JSX children must be explicitly wrapped:
// Current - requires manual wrapping<span>{Jsx.string("hello")}</span><> {Jsx.string("world")} </>// What developers want to write<span>hello</span><>world </>
Solution
Modified the JSX children parser incompiler/syntax/src/res_core.ml to automatically detect string literals and wrap them withJsx.string() calls during AST construction.
If you need me to access, download, or install something from one of these locations, you can either:
ConfigureActions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository'sCopilot coding agent settings (admins only)
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.
CopilotAI changed the title[WIP] Right now children of a JSX element in Rescript must be of typeJsx.element, for exampleres<span>hello</span>expects ahello variable of typeJsx.element,we want to change this so it'd be an equivalent of: ```res<span>{Jsx.string("h...Automatically wrap JSX string literals with Jsx.string()Sep 9, 2025
@nojaf nice! The handling of whitespace inside HTML/JSX is such a mess though, good luck with that! I'll then focus on wrapping variables inside curly braces for now then. This way, users of V12 will have their projects automatically formatted and we can introduce your work in v12.1 (or as soon as it's ready!)!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR implements automatic wrapping of string literals in JSX children with
Jsx.string()calls, eliminating the need for manual wrapping.Problem
Currently, string literals in JSX children must be explicitly wrapped:
Solution
Modified the JSX children parser in
compiler/syntax/src/res_core.mlto automatically detect string literals and wrap them withJsx.string()calls during AST construction.Implementation Details
Added
wrap_jsx_string_literalfunction that:Pexp_constant (Pconst_string ...))Jsx.string(originalString)function callsIntegrated into
parse_jsx_children:Examples
After this change, the following transformations happen automatically:
Backward Compatibility
<span>{Jsx.string("hello")}</span><span>{someVariable}</span>Test Cases
Added comprehensive test cases to
tests/syntax_tests/data/parsing/grammar/expressions/jsx.rescovering:The implementation follows established patterns in the ReScript compiler codebase and maintains full compatibility with existing JSX usage patterns.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)opam.ocaml.org/usr/bin/curl --write-out %{http_code}\n --retry 3 --retry-delay 2 --user-agent opam/2.1.5 -L -o /tmp/opam-5289-e2dcfc/index.tar.gz.part -- REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.