- Notifications
You must be signed in to change notification settings - Fork471
Fix generation of interfaces for module types containing multiple type constraints#7825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mediremi merged 3 commits intorescript-lang:masterfrommediremi:create-interface-module-multi-typesAug 31, 2025
Merged
Fix generation of interfaces for module types containing multiple type constraints#7825
mediremi merged 3 commits intorescript-lang:masterfrommediremi:create-interface-module-multi-typesAug 31, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| print_out_type_doc typ; | ||
| ] | ||
| in | ||
| incr i; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Without thisincr i,i.contents was always 0
rescript@rescript/darwin-arm64@rescript/darwin-x64@rescript/linux-arm64@rescript/linux-x64@rescript/runtime@rescript/win32-x64commit: |
zth approved these changesAug 30, 2025
22f68af intorescript-lang:master 25 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
When creating an interface file with
rescript-editor-analysis createInterface SomeFile.res, invalid syntax was being generated for module types containing multiple type constraints.For example:
was being converted to interface:
but
with type identity = 'a with type t = 'bis invalid syntax and should have beenwith type identity = 'a and type t = 'b(notice the secondwithbecomesand).res_outcome_printerdid have existing logic to emitandinstead ofwith, but it relied on a ref counter that was not being incremented.