NotificationsYou must be signed in to change notification settings
Fork471
Star7.2k

Hint about partial application in error where required labels are missing#7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

zth merged 3 commits intomasterfromerror-hint-partial-application

Aug 26, 2025

Merged

Hint about partial application in error where required labels are missing#7807

zth merged 3 commits intomasterfromerror-hint-partial-application

Aug 26, 2025

Conversation

Copy link

Member

zth commentedAug 25, 2025

Just a small tweak. Happy for feedback on the hint message itself.

I'll add a changelog just before merging.

zth requested review frommediremi,nojaf andtsnobip

August 25, 2025 16:35

Copy link

pkg-pr-newbot commentedAug 25, 2025•
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7807

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7807

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7807

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7807

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7807

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7807

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7807

commit:c5bd1ff

mediremi reviewed

Aug 25, 2025

View reviewed changes

tests/build_tests/super_errors/expected/moreArguments4.res.expected Outdated


		- Missing arguments that must be provided: ~d, ~c, ~b
		- Missing arguments that must be provided: ~d, ~c, ~b
		- Hint: Did you want to partially apply the function? You can do that by putting `...` just before the closing parens of the function call

Copy link

Member

mediremiAug 25, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Would it be possible to give a code example using the actual function and args the user tried to apply?

- Hint: Did you want to partially apply the function?  You can do that by putting `...` just before the closing parens of the function call:  f(v, ...)

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Definitely! Just problematic if the function application is large, but maybe it's fine.

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@mediremi turns out we're not in the error reporting place where we have the "rewrite the expr and show" facilities we normally have. But, I added a generic example that I think is good enough:c137929

What do you think?