- Notifications
You must be signed in to change notification settings - Fork471
Dedicated error message for ternaries#7804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| (* TODO(attributes) Unify the attribute handling in the parser and rest of the compiler.*) | ||
| let is_ternary= | ||
| letrechas_ternary=function | ||
| |[] ->false | ||
| | ({Location.txt ="res.ternary"},_) ::_ ->true | ||
| |_ ::rest -> has_ternary rest | ||
| in | ||
| has_ternary sexp.pexp_attributes | ||
| in | ||
| let return_context= | ||
| if is_ternarythenSomeTernaryReturnelseSomeIfReturn | ||
| in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Putting in my TODO to unify all of these attribute names across the syntax and compiler. A lot of them should probably be proper AST nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would be great to track this in an issue instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done#7805
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds a dedicated error message for ternary operators, distinguishing them from general if statement errors. Previously, ternary expressions used the same error messages as if statements since they desugar to if-then-else constructs.
- Adds a new
TernaryReturncontext type to differentiate ternary expressions from if statements - Updates error message formatting to specifically mention ternaries with
?and:operators - Adds test case demonstrating the new error message for type mismatches in ternary branches
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
compiler/ml/typecore.ml | Detects ternary expressions via attributes and usesTernaryReturn context instead ofIfReturn |
compiler/ml/error_message_utils.ml | AddsTernaryReturn context type and corresponding error message formatting |
tests/build_tests/super_errors/fixtures/ternary_branch_mismatch.res | Test fixture with ternary type mismatch |
tests/build_tests/super_errors/expected/ternary_branch_mismatch.res.expected | Expected error output showing the new ternary-specific error message |
Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.
| let is_ternary= | ||
| letrechas_ternary=function | ||
| |[] ->false | ||
| | ({Location.txt ="res.ternary"},_) ::_ ->true |
CopilotAIAug 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The magic string "res.ternary" should be defined as a constant to avoid duplication and make it easier to maintain if the attribute name changes.
| let is_ternary= | |
| letrechas_ternary=function | |
| |[] ->false | |
| | ({Location.txt ="res.ternary"},_) ::_ ->true | |
| let res_ternary_attribute="res.ternary"in | |
| let is_ternary= | |
| letrechas_ternary=function | |
| |[] ->false | |
| | ({Location.txt =res_ternary_attribute},_) ::_ ->true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice improvement 💪
rescript@rescript/darwin-arm64@rescript/darwin-x64@rescript/linux-arm64@rescript/linux-x64@rescript/win32-x64commit: |
3931a96 intomasterUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice improvement! Thanks@zth !
The general if error was used before (because that's what the ternary desugars to). This gives ternaries a dedicated error.