- Notifications
You must be signed in to change notification settings - Fork471
Add support for the bitwise NOT(~) unary operator#7418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
~) unary operatorpkg-pr-newbot commentedMay 4, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
rescript@rescript/darwin-x64@rescript/linux-arm64@rescript/linux-x64@rescript/win32-x64@rescript/darwin-arm64commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice work! 🎉 Just left some comments.
@cristianoc could you review, too?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| letis_es6_arrow_expression~in_ternaryp= | ||
| Parser.lookahead p (funstate -> | ||
| letasync= | ||
| let_async= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I wonder why we didn't get a warning before if this is unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It was used for recovery on tilde token, I forgot to rollback the recovery change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe not. we should remove the tilde handling because now we allow to use it somewhere in that context.
| ;;call (~ a) | ||
| ;;call ~a:(a ^ (~ a)) | ||
| ;;call ~a:(~ a) | ||
| ;;call_partial 3 ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you add some simple examples too? E.g.let z = ~y. To illustrate where parens are added, and where they are not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it has been added in theunary.res file already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me. Left a minor question.
| |EqualGreater ->true | ||
| |_ ->false) | ||
| |Dot(* uncurried*) ->true | ||
| |Tildewhennot async ->true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Here where we use theasync bool value before
I'm merging this and continuing to work on the Let me know if there's still something that needs to be fixed |
c65c6c0 intorescript-lang:masterUh oh!
There was an error while loading.Please reload this page.
Part of the#7172
Allows to use
~in unary expressions, and make it as compiler primitive instead of using runtime library codeThere is one syntax ambiguity problem with function arguments as we already use tilde token for the labeled argument syntax, e.g.
So we decided to enforce parens on that case.
And also we add parens in binary expressions too:
Note: unlike existing
+and-,~nis not being parsed as constant, only expression