Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add bitxor (^) unified operator#7216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@MiryangJung
Copy link
Contributor

@MiryangJungMiryangJung commentedDec 24, 2024•
edited
Loading

#7172

When running make lib locally, the build is failing, and I’m currently checking it.

jeong-sik, tsnobip, and GzuPark reacted with thumbs up emoji
@zth
Copy link
Member

zth commentedDec 24, 2024

@MiryangJung great to see you in a PR, welcome! 😁

MiryangJung, cknitt, and tsnobip reacted with thumbs up emojiMiryangJung, cknitt, and tsnobip reacted with hooray emojiMiryangJung, cknitt, and tsnobip reacted with heart emoji

@cknitt
Copy link
Member

Hi@MiryangJung! Would be great to get this PR merged - do you have time to pick up work on it again?

@MiryangJung
Copy link
ContributorAuthor

Hi@MiryangJung! Would be great to get this PR merged - do you have time to pick up work on it again?

sure! I will redo the task.

@cometkimcometkim mentioned this pull requestMar 22, 2025
@MiryangJungMiryangJungforce-pushed theunified-operator/lxor branch 3 times, most recently from4d0f26a tobd8ceb3CompareMarch 22, 2025 14:50
@cometkimcometkim marked this pull request as ready for reviewMarch 22, 2025 14:50
@MiryangJungMiryangJung changed the titleadd add lxor (^) unified operatoradd add bitxor (^) unified operatorMar 22, 2025
@MiryangJungMiryangJung changed the titleadd add bitxor (^) unified operatoradd bitxor (^) unified operatorMar 22, 2025
MiryangJungand others added2 commitsMarch 23, 2025 09:30
Co-authored-by: Hyeseong Kim <hey@hyeseong.kim>
Co-authored-by: Christoph Knittel <christoph@knittel.cc>
@cknitt
Copy link
Member

Please also update the test output accordingly.

MiryangJung reacted with thumbs up emoji

@MiryangJung
Copy link
ContributorAuthor

update the test output

oh! thx

@cknitt
Copy link
Member

Oh, and could you also add a CHANGELOG entry, please?

@MiryangJung
Copy link
ContributorAuthor

Oh, and could you also add a CHANGELOG entry, please?

Ok! I've added it. But I'm not sure if I did it correctly 🤨

@cknitt
Copy link
Member

Oh, and could you also add a CHANGELOG entry, please?

Ok! I've added it. But I'm not sure if I did it correctly 🤨

Thanks a lot! I adapted it a bit.

MiryangJung and GzuPark reacted with heart emoji

@cknittcknitt merged commita7d34c7 intorescript-lang:masterMar 25, 2025
20 checks passed
@fhammerschmidtfhammerschmidt mentioned this pull requestApr 3, 2025
4 tasks
fhammerschmidt pushed a commit that referenced this pull requestApr 4, 2025
* add add lxor (^) unified operator* add bitxorCo-authored-by: Hyeseong Kim <hey@hyeseong.kim>* Update compiler/syntax/src/res_diagnostics.mlCo-authored-by: Christoph Knittel <christoph@knittel.cc>* update the test output* CHANGELOG: Add unified bitwise (`^`) operator to the list of changes* Update CHANGELOG.md---------Co-authored-by: Hyeseong Kim <hey@hyeseong.kim>Co-authored-by: Christoph Knittel <christoph@knittel.cc>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@cometkimcometkimcometkim left review comments

@cknittcknittcknitt approved these changes

@cristianoccristianocAwaiting requested review from cristianoc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MiryangJung@zth@cknitt@cometkim
[8]ページ先頭
©2009-2025 Movatter.jp