Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(fetch): addResponse.json static method#10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mcansh wants to merge5 commits intomain
base:main
Choose a base branch
Loading
fromlogan/response.json

Conversation

mcansh
Copy link
Collaborator

@mcanshmcansh commentedMay 25, 2022•
edited
Loading

remix-run/remix#3308

======================================================================================

confirmed working withnpm link and importing Response from@remix-run/web-fetch

image

jmezzacappa reacted with thumbs up emoji
@changeset-bot
Copy link

changeset-botbot commentedMay 25, 2022•
edited
Loading

🦋 Changeset detected

Latest commit:857eec9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@remix-run/web-fetchPatch

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcanshmcanshforce-pushed thelogan/response.json branch fromd819f93 tof8855c9CompareMay 25, 2022 21:37
@kettanaito
Copy link

As far as I know, there's noResponse.json static method on the Fetch API Response class. If this is a convenience feature, I'd highly encourage you not to add it to the Response class directly.

I'm solving a similar convenience issue in MSW, and you can draw some inspiration fromthere.

@mcansh
Copy link
CollaboratorAuthor

it's in thespec and implemented in chrome, so it really just makes our polyfill closer to the spec

kettanaito reacted with thumbs up emoji

@kettanaito
Copy link

@mcansh, a good point, I must've been using a really old version of Chrome so it didn't show up when I checked this. Thanks for correcting me!

@mcanshmcansh marked this pull request as ready for reviewNovember 6, 2023 23:36
@MichaelDeBoeyMichaelDeBoey changed the titlefeat: add Response.json static methodfeat(fetch): addResponse.json static methodApr 7, 2025
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
[skip ci]Signed-off-by: Logan McAnsh <logan@mcan.sh>
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@brophdawg11brophdawg11 removed their request for reviewMay 1, 2025 20:26
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@MichaelDeBoeyMichaelDeBoeyMichaelDeBoey approved these changes

@jacob-ebeyjacob-ebeyAwaiting requested review from jacob-ebey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@mcansh@kettanaito@MichaelDeBoey@jacob-ebey
[8]ページ先頭
©2009-2025 Movatter.jp