Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Retaining the modified title on component unmount made optional.#2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iamsolankiamit merged 2 commits intorehooks:masterfromkckusal:retaining-modified-title-made-optional
Apr 23, 2020
Merged

Retaining the modified title on component unmount made optional.#2

iamsolankiamit merged 2 commits intorehooks:masterfromkckusal:retaining-modified-title-made-optional
Apr 23, 2020

Conversation

@kckusal
Copy link
Contributor

Option added to retain the modified title or to rollback to the default title ON the corresponding component unmount event (e.g. route change -> title change for those using this hook, but rollback to the default/original title for those routes not using this hook.)

…lt title ON the corresponding component unmount event (e.g. route change -> title change for those using this hook, but rollback to the default/original title for those routes not using this hook.)
@iamsolankiamit
Copy link
Member

@kckusal can you squash the commits into one commit. we can merge after that

@kckusal
Copy link
ContributorAuthor

@iamsolankiamit I have pushed the commits to my branchretaining-modified-title-made-optional already.. I don't have write access to your repo to squash commits and merge pull requests directly though.

I only recently started to collaborate in GitHub, so bear with me if I missed something here.. :)

@iamsolankiamitiamsolankiamit merged commit56dba6f intorehooks:masterApr 23, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@iamsolankiamitiamsolankiamitiamsolankiamit requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kckusal@iamsolankiamit

[8]ページ先頭

©2009-2025 Movatter.jp