NotificationsYou must be signed in to change notification settings
Fork666
Star19.1k

cacheSize option for defaultMemoize#210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

b6pzeusbc54tvhw5jgpyw8pwz2x6gs wants to merge3 commits intoreduxjs:masterfromb6pzeusbc54tvhw5jgpyw8pwz2x6gs:master

Closed

cacheSize option for defaultMemoize#210

b6pzeusbc54tvhw5jgpyw8pwz2x6gs wants to merge3 commits intoreduxjs:masterfromb6pzeusbc54tvhw5jgpyw8pwz2x6gs:master

Conversation

Copy link

b6pzeusbc54tvhw5jgpyw8pwz2x6gs commentedJan 10, 2017

As 3rd argument, now defaultMemoize() can get thecacheSize.

There are two arrays to store previous argument arrays, previous results.

let cacheArgsArr = []let cacheREsultArr = []

cacheSize feature is designed as follows:

const createSelector = createSelectorCreator( defaultMemoize, void 0, 2 )const powerSelector = createSelector([      (state)=>state.num], ( num )=> num*num )console.log( powerSelector({ num: 1 }) )            // 1 (recomputation)console.log( powerSelector.getCacheArgsArr() )      // [ [1] ]console.log( powerSelector.getCacheResultArr() )    // [1]console.log( powerSelector({ num: 2 }) )            // 4 (recomputation)console.log( powerSelector.getCacheArgsArr() )      // [ [2],[1] ]console.log( powerSelector.getCacheResultArr() )    // [ 4, 1 ]console.log( powerSelector({ num: 3 }) )            // 9 (recomputation)console.log( powerSelector.getCacheArgsArr() )      // [ [3],[2] ]console.log( powerSelector.getCacheResultArr() )    // [ 9, 4 ]console.log( powerSelector({ num: 2 }) )            // 4 (cache)console.log( powerSelector.getCacheArgsArr() )      // [ [2],[3] ]console.log( powerSelector.getCacheResultArr() )    // [ 4, 9 ]

In general, there is high a probability that last argument is used again.
So last arguemnts and result are added or updated to index: 0 in cacheArgsArrandcacheResultArr`

Please feel free to contact us if you have something lacking.

b6pzeusbc54tvhw5jgpyw8pwz2x6gs added3 commits

January 11, 2017 01:53

add cache size option to defaultMemoize

ec1fb41

add some test case

78387c7

some rename, fix typo

484b0a1

Copy link

codecov-io commentedJan 10, 2017•
edited
Loading

Current coverage is 100% (diff: 100%)

Merging#210 intomaster will not change coverage

@@           master   #210   diff @@====================================  Files           1      1            Lines          12     18     +6     Methods         0      0            Messages        0      0            Branches        0      0          ====================================+ Hits           12     18     +6  Misses          0      0            Partials        0      0

Powered byCodecov. Last update1143dcb...484b0a1

Copy link

coveralls commentedJan 10, 2017•
edited
Loading

Coverage remained the same at 100.0% when pulling484b0a1 on b6pzeusbc54tvhw5jgpyw8pwz2x6gs:master into1143dcb on reactjs:master.

3 similar comments

Copy link

coveralls commentedJan 10, 2017

Coverage remained the same at 100.0% when pulling484b0a1 on b6pzeusbc54tvhw5jgpyw8pwz2x6gs:master into1143dcb on reactjs:master.

Copy link

coveralls commentedJan 10, 2017

Coverage remained the same at 100.0% when pulling484b0a1 on b6pzeusbc54tvhw5jgpyw8pwz2x6gs:master into1143dcb on reactjs:master.

Copy link

coveralls commentedJan 10, 2017

Coverage remained the same at 100.0% when pulling484b0a1 on b6pzeusbc54tvhw5jgpyw8pwz2x6gs:master into1143dcb on reactjs:master.

ndbroadbent mentioned this pull request

Mar 29, 2017

Added a simple FIFO cache to defaultMemoize, with a cacheSize option#238

Closed

Copy link

ivawzh commentedApr 21, 2018•
edited
Loading

Thank@b6pzeusbc54tvhw5jgpyw8pwz2x6gs , this was an enlightenment.
What do you think about the already supported selector customization below:

importmemoizerfrom'fast-memoize'import{createSelectorCreator}from'reselect'// Why not Lodash's memoize?// Because that won't work when the function takes more than one argument. And this is fast.exportconstcreateSelector=createSelectorCreator(memoizer)

fast-memoize allows unlimited cache size.

Copy link

adnelson commentedNov 6, 2019

@ivawzh that's a great solution -- it would be super helpful if this were in theREADME.md. It suggests to "Create a custom selector with a cache size greater than one." But doesn't provide any guidance on how to do so.