this is not required with the new context any longer, we can change the context value and children are updated

But, the selector initialization and binding of action creators happens when the connected children are instantiated - we don't try to re-bind those if the store is swapped out.

We can rebind in cDU, 1 line change

Not something I'm particularly worried about right now. There may besomeone out there who has a need to swap out their store, but it's not something we've ever supported and I don't see a need to try to support it for the time being.

here, I would rather do the calculation of derived props and memoize them, then the inner component need only be the WrappedComponent or a PureComponent that wraps it, something like:

constInner=connectOptions.pure ?classInnerextendsPureComponent{render(){return<WrappedComponent{...this.props}/>}} :WrappedComponent

then renderInner can be something like:

renderInner({ storeState, store}){constprops=this.propsconstderivedProps=this.memoizedProps(storeState,props)return<Inner{...props}{...derivedProps}/>}

Our memoizer can be initialized in the constructor withthis.memoizedProps = this.makeMemoizer()

makeMemoizer(){letlastPropsletlastStateletlastDerivedPropsletcalled=falsereturn(state,props)=>{if(called){constsameProps=connectOptions.pure&&shallowEqual(lastProps,props)constsameState=lastState===stateif(sameProps&&sameState){returnlastDerivedProps}}called=truelastProps=propslastState=stateconstnextProps=this.state.childPropsSelector(state,props)if(shallowEqual(lastDerivedProps,nextProps)){returnlastDerivedProps}lastDerivedProps=nextPropsreturnlastDerivedProps}}

In this way, we don't needgetDerivedStateFromProps at all

Let's try that approach as a second PR, for comparison purposes.

I still think we can manage this, but by allowing passing a separate context consumer to connect. This way, users can use a custom context provider and just hook into it with their specific components. In other words, we providecreateProviderContext and allow:

const{ SpecialProvider, SpecialConsumer}=createProviderContext()constConnectedNormal=connect(...)(Thing)constConnectedOther=connect(mSP,mDP,merge,{contextConsumer:SpecialConsumer})(Thing)functionSomething(){return(<Providerstore={store}><Providercontext={SpecialProvider}store={store2}><ConnectedNormal><ConnectedOther/></ConnectedNormal></Provider></Provider>)}

This way, we get the full advantage of React's context, but have flexibility.

We could potentially allow passing aContext.Consumer directly to a connected component as a prop, although we might have to do some fiddling around because this currently tries to pass all the wrapper props down directly to the inner component.

That said, I'm not worried about trying to implement store-as-a-prop or anything like that atm. My main concern is getting the data flow and update behavior working right - we can add everything else after that.