Jun 16, 2016 · Jun 16, 2016 · Jun 16, 2016 · Jun 16, 2016 · Jun 16, 2016 · Jun 16, 2016
diff --git a/src/components/connect.js b/src/components/connect.js
 import { createSelector } from 'reselect'
 import warning from '../utils/warning'

 importconnectToStore, { createShallowEqualSelector } from './connectToStore'
 importconnectAdvanced, { createShallowEqualSelector } from './connectAdvanced'

 const defaultMergeProps = (stateProps, dispatchProps, ownProps) => ({
  ...ownProps,
    ))
  }

  returnconnectToStore(
  returnconnectAdvanced(
    selectorFactory,
    {
      pure,
diff --git a/src/components/connectToStore.js → src/components/connectAdvanced.js b/src/components/connectToStore.js → src/components/connectAdvanced.js

 let hotReloadingVersion = 0

 export default functionconnectToStore(
 export default functionconnectAdvanced(
  /*
 thisfunc is responsible for returning the selector function used to compute new props from
    state, props, and dispatch. For example:
 selectorFactory is afunc is responsible for returning the selector function used to compute new
 props fromstate, props, and dispatch. For example:

      export defaultconnectToStore(() => (state, props, dispatch) => ({
      export defaultconnectAdvanced(() => (state, props, dispatch) => ({
        thing: state.things[props.thingId],
        saveThing: fields => dispatch(actionCreators.saveThing(props.thingId, fields)),
      }))(YourComponent)

    Alternatively, it can return a plain object which will be passed to reselect's
    'createStructuredSelector' function to create the selector. For example:

      returnconnectToStore(() => ({
      returnconnectAdvanced(() => ({
        thing: (state, props) => state.things[props.thingId],
        saveThing: (_, props, dispatch) => fields => (
          dispatch(actionCreators.saveThing(props.thingId, fields))
    This is equivalent to wrapping the returned object in a call to `createStructuredSelector`,
    but is supported as a convenience; This is the recommended approach to defining your
    selectorFactory methods. The above example can be simplfied by using the `dispatchable` helper
    method provided withconnectToStore:
    method provided withconnectAdvanced:

 connectToStore(() => ({
 connectAdvanced(() => ({
        thing: (state, props) => state.things[props.thingId],
        saveThing: dispatchable(actionCreators.saveThing, (_, props) => props.thingId),
      }))(YourComponent)
  // options object:
  {
    // the func used to compute this HOC's displayName from the wrapped component's displayName.
    getDisplayName = name => `connectToStore(${name})`,
    getDisplayName = name => `connectAdvanced(${name})`,

    // shown in error messages
    methodName = 'connectToStore',
    methodName = 'connectAdvanced',

    // if true, shouldComponentUpdate will only be true of the selector recomputes for nextProps.
    // if false, shouldComponentUpdate will always be true.
diff --git a/src/index.js b/src/index.js
 import Provider from './components/Provider'
 import connect from './components/connect'
 importconnectToStore, { dispatchable } from './components/connectToStore'
 importconnectAdvanced, { dispatchable } from './components/connectAdvanced'

 export { Provider, connect,connectToStore, dispatchable }
 export { Provider, connect,connectAdvanced, dispatchable }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -3,7 +3,7 @@ import { bindActionCreators } from 'redux'
		import { createSelector } from 'reselect'
		import warning from '../utils/warning'

		importconnectToStore, { createShallowEqualSelector } from './connectToStore'
		importconnectAdvanced, { createShallowEqualSelector } from './connectAdvanced'

		const defaultMergeProps = (stateProps, dispatchProps, ownProps) => ({
		...ownProps,
Expand DownExpand Up		@@ -98,7 +98,7 @@ export default function connect(
		))
		}

		returnconnectToStore(
		returnconnectAdvanced(
		selectorFactory,
		{
		pure,
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -34,20 +34,20 @@ export function dispatchable(actionCreator, ...selectorsToPartiallyApply) {

		let hotReloadingVersion = 0

		export default functionconnectToStore(
		export default functionconnectAdvanced(
		/*
		thisfunc is responsible for returning the selector function used to compute new props from
		state, props, and dispatch. For example:
		selectorFactory is afunc is responsible for returning the selector function used to compute new
		props fromstate, props, and dispatch. For example:

		export defaultconnectToStore(() => (state, props, dispatch) => ({
		export defaultconnectAdvanced(() => (state, props, dispatch) => ({
		thing: state.things[props.thingId],
		saveThing: fields => dispatch(actionCreators.saveThing(props.thingId, fields)),
		}))(YourComponent)

		Alternatively, it can return a plain object which will be passed to reselect's
		'createStructuredSelector' function to create the selector. For example:

		returnconnectToStore(() => ({
		returnconnectAdvanced(() => ({
		thing: (state, props) => state.things[props.thingId],
		saveThing: (_, props, dispatch) => fields => (
		dispatch(actionCreators.saveThing(props.thingId, fields))
Expand All		@@ -57,9 +57,9 @@ export default function connectToStore(
		This is equivalent to wrapping the returned object in a call to `createStructuredSelector`,
		but is supported as a convenience; This is the recommended approach to defining your
		selectorFactory methods. The above example can be simplfied by using the `dispatchable` helper
		method provided withconnectToStore:
		method provided withconnectAdvanced:

		connectToStore(() => ({
		connectAdvanced(() => ({
		thing: (state, props) => state.things[props.thingId],
		saveThing: dispatchable(actionCreators.saveThing, (_, props) => props.thingId),
		}))(YourComponent)
Expand All		@@ -73,10 +73,10 @@ export default function connectToStore(
		// options object:
		{
		// the func used to compute this HOC's displayName from the wrapped component's displayName.
		getDisplayName = name => `connectToStore(${name})`,
		getDisplayName = name => `connectAdvanced(${name})`,

		// shown in error messages
		methodName = 'connectToStore',
		methodName = 'connectAdvanced',

		// if true, shouldComponentUpdate will only be true of the selector recomputes for nextProps.
Copy link emmadavieswilcoxJul 7, 2016 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. `...will only be true of the selector recomputes...` Should that be`if` rather than`of`?
		// if false, shouldComponentUpdate will always be true.
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -1,5 +1,5 @@
		import Provider from './components/Provider'
		import connect from './components/connect'
		importconnectToStore, { dispatchable } from './components/connectToStore'
		importconnectAdvanced, { dispatchable } from './components/connectAdvanced'

		export { Provider, connect,connectToStore, dispatchable }
		export { Provider, connect,connectAdvanced, dispatchable }