Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.3k
[DRAFT] Prototype use of autotracking to optimize subscription behavior#2047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
markerikson wants to merge8 commits intomasterChoose a base branch fromfeature/tracking-subscriptions
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codesandbox-cibot commentedJun 26, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commitbbf7a4f:
|
0751acc tobbf7a4fCompare Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR:
SubscriptionanduseSelectorto try using autotracking to optimize subscription behavior and avoid executing subscriber+selector callbacks that we already know try to read state that didn't change.For background on autotracking, see:
Notes:
Subscription.tsanduseSelector.tsfiles. My plan is that if I can get this working, I would instead copy-paste the logic into separatecreateTrackedSubscriptionanduseTrackedSelectorfiles, and that you would enable the top-level tracking behavior by passing<Provider createSubscription={createTrackedSubscription}>. That way no one would have to pay the bundle size cost for the additional tracking logic unless they opt in,and all existinguseSelectorusage stays exactly the same.stateis an object, not a primitive. That should be the case in most apps. (Naturally, a bunch of our testsdo have just a primitive like0as the state...)useSelectortest suite all passes. Either I've done something very right, or I've done something that has no use at all :)O(n). It's entirely possible everything I've got here is a waste of effort because you're still calling a ton of functions.But now that I've gotsomething that appears to at least run and pass tests, I can start doing more investigation.