Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Updated: Support React-Hot-Loader compatibility#1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
markerikson merged 2 commits intomasterfromsupport-react-hot-loader
Jan 20, 2019

Conversation

@markerikson
Copy link
Contributor

Rebased version of#1137 , by@theKashey.

Perf benchmarks indicate no noticeable difference in performance.

Tagging@timdorr ,@shahzaibkhalid , and@glenjamin who were participating in the other thread.

shahzaibkhalid, sabonis, and hhaidar reacted with thumbs up emoji
theKasheyand others added2 commitsJanuary 20, 2019 16:54
The test runner script tried to pass the Jest config asstringified JSON, but that was breaking for me somehow.Sidestepped the problem by writing the settings to disk insteadand pointing Jest to that file.
@netlify
Copy link

netlifybot commentedJan 20, 2019

Deploy preview forreact-redux-docs ready!

Built with commitd78dd73

https://deploy-preview-1168--react-redux-docs.netlify.com

@markerikson
Copy link
ContributorAuthor

And merging.

@markeriksonmarkerikson merged commit6e0a106 intomasterJan 20, 2019
@markerikson
Copy link
ContributorAuthor

@timdorr : might as well go ahead and put out 6.0.1 with this and the "is it a real context?" change.

shahzaibkhalid, ericdfields, and hhaidar reacted with thumbs up emojitheKashey, ericdfields, and hhaidar reacted with hooray emoji

@theKashey
Copy link

👍

@ericdfields
Copy link

Thank you!

@timdorrtimdorr deleted the support-react-hot-loader branchJanuary 22, 2019 15:17
@hhaidar
Copy link

💯 to 6.0.1

shahzaibkhalid, efstathiosntonas, and Aman9804 reacted with rocket emoji

@GerryFudd
Copy link

Looks like react-redux 7.0.0 causes connected components to not load when used with react-hot-loader. Should that be filed as a separate ticket or should this one be re-opened?

@theKashey
Copy link

theKashey commentedJun 7, 2019•
edited
Loading

Please updatereact-hot-loader to the latest version (4.9.0, released a week ago) which does support hooks hot reloading, v7 is based on.
Any older version would have issues withreact-redux v7.

martynaskadisa reacted with hooray emoji

albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull requestDec 8, 2022
* fix: react-hot-loader compatibility* Fix test runner breakingThe test runner script tried to pass the Jest config asstringified JSON, but that was breaking for me somehow.Sidestepped the problem by writing the settings to disk insteadand pointing Jest to that file.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@markerikson@theKashey@ericdfields@hhaidar@GerryFudd
[8]ページ先頭
©2009-2025 Movatter.jp