Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.3k
Minor optimization: remove conditional#1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The conditional in selectDerivedProps is unnecessary. The code behavesidentically now but saves about 10% of performance for that portion ofthe function.See:https://jsperf.com/conditional-vs-notCode left in place but commented in case someone ever wants to addsomething like it back for "clarity".
netlifybot commentedDec 14, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Deploy preview forreact-redux-docs ready! Built with commit7da8c0d |
Thanks! |
albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull requestDec 8, 2022
* Minor optimization: remove conditionalThe conditional in selectDerivedProps is unnecessary. The code behavesidentically now but saves about 10% of performance for that portion ofthe function.See:https://jsperf.com/conditional-vs-notCode left in place but commented in case someone ever wants to addsomething like it back for "clarity".* Just remove the code
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conditional in selectDerivedProps is unnecessary. The code behaves
identically now but saves about 10% of performance for that portion of
the function.
See:https://jsperf.com/conditional-vs-not
Code left in place but commented in case someone ever wants to add
something like it back for "clarity".