Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

BREAKING: Remove symbol from type#86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JaKXz merged 6 commits intoredux-utilities:masterfromunional:patch-3
Nov 2, 2017

Conversation

@unional
Copy link
Contributor

Fix#39

@coveralls
Copy link

coveralls commentedOct 27, 2017•
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling6a56bfa on unional:patch-3 intof509286 on acdlite:master.

@JaKXz
Copy link
Contributor

This is something that should be reflected in the exported methods as well.

@JaKXz
Copy link
Contributor

I believe this would also resolve#9, if there's general support for it.

Copy link
Contributor

@JaKXzJaKXz left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for taking the time on this,@unional.

I'm just going to mass ping folks, before just going ahead and merging.

@gaearon@acdlite@yangmillstheory@timche @ anyone else!

exportfunctionisFSA(action){
return(
isPlainObject(action)&&
(isString(action.type)||isSymbol(action.type))&&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is an import that needs to be removed as well.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks. I was editing on github directly. Missed the import. 😛

@coveralls
Copy link

coveralls commentedOct 30, 2017•
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling9a5ffeb on unional:patch-3 intof509286 on acdlite:master.

@timche
Copy link
Member

Looks good 👍

@JaKXzJaKXz merged commit6919306 intoredux-utilities:masterNov 2, 2017
@unionalunional deleted the patch-3 branchNovember 19, 2017 08:24
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@JaKXzJaKXzJaKXz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@unional@coveralls@JaKXz@timche
[8]ページ先頭
©2009-2025 Movatter.jp