Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Makemeta property optional#76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
chrisjarman wants to merge2 commits intoredux-utilities:masterfromchrisjarman:master
Closed

Makemeta property optional#76

chrisjarman wants to merge2 commits intoredux-utilities:masterfromchrisjarman:master

Conversation

@chrisjarman
Copy link

This PR corrects the interface definition forFluxStandardAction, making themeta property optional.

Chris Hunt added2 commitsSeptember 4, 2017 13:53
Update to v2.0.0 after potentially-breaking change to type definitions
@chrisjarman
Copy link
Author

Ah, sorry, I now see that this has been addressed before. I'll respectfully leave the PR open, because I think the interface definition for an "optional" property (as spec'ed in the docs) should allow the total omission of the property, if the user so desires. Forcing the presence of a property whose value isundefined ornull is over-opinionated, in my book. YMMV.

wub reacted with thumbs up emoji

@JaKXz
Copy link
Contributor

@linguamachina thank you for the PR. What do you think of the discussion in#53? To me it seems this question has a lot of back and forth... I'm not a daily TS user so I'm not sure what the best course going forward is.

@JaKXz
Copy link
Contributor

Closing in favour of#94.

@JaKXzJaKXz closed thisDec 2, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chrisjarman@JaKXz
[8]ページ先頭
©2009-2025 Movatter.jp