@bkonkle thanks for the contribution - I think in the time that this PR was made and now the lodash file sizes have improved, and I just tested v1.1.0 and found it to be < 10k [uncompressed and not uglified] includingindex.js and all dependencies. Let me know if you see anything wildly different from this.

Improvements like this are welcome though, so if you find something else, feel free to crack open another PR! :)

It's very sad it is closed, because it's a pain to use redux-promise -> flux-standard-actions with SystemJS. Because when I agreed to configure lodash.isplainobject, it required yet more 4 modules: _basefor, isarguments, isarray, keysin. My config.js is getting bigger and bigger, and soon exceeds a size of lodash

@JaKXz instead of replacinglodash modular dependencies, would you consider switching dependencies tolodash main module and import from its entries? For example,

Before

importisPlainObjectfrom'lodash.isplainobject';importisStringfrom'lodash.isstring';importisSymbolfrom'lodash.issymbol';

After

importisPlainObjectfrom'lodash/isPlainObject';importisStringfrom'lodash/isString';importisSymbolfrom'lodash/isSymbol';

Thus, for those users who's also usinglodash in their user space, the bundler (rollup/webpack) could resolve these modules and create a smaller output. What do you think?

One benefit of this approach is user can combine withbabel-plugin-lodash and thus preventing importing the wholelodash into their bundle.

Hey@tomchentw I think that's a reasonable suggestion, want to make a PR? :)

I have a broader, naive question though, probably for@jdalton:

Would it be possible to havelodash itself depend on all thelodash.* modules and just export them under the one var_? There's probably a maintenance issue I'm not thinking of, but perhaps lerna can help with that?

Hi@JaKXz!

Thelodash.* packages are self-contained, zero dependency, packages. This means there'd likely be duplication. The preferred route would be to use something likebabel-plugin-lodash. In v5 we're dropping the monolithic file altogether opting for folks to use the babel plugin if they want the monolithic-like syntax.

In the case of this PR though simply upgradinglodash.isplainobject to^4.0.0 would get you reduced deps as it now has no deps. You can look to others like redux which cherry-pick Lodash'slodash/isPlainObject as well into their package build.

@jdalton thanks for the reply :)

I believe we were at^4.0.0:https://github.com/acdlite/flux-standard-action/blob/01e8fc3cb9fa80fe49b816a9d65d1ad9c85c3180/package.json#L56

but yeah that's a good idea, I'll take a look at redux.

If you go the redux route you can combo withlodash-webpack-plugin for an even smaller bundle.

I've created the PR#51 to address it.