Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Lodash optimization#120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timche merged 1 commit intoredux-utilities:masterfromVadimKorobka:master
Jul 31, 2021
Merged

Conversation

@VadimKorobka
Copy link
Contributor

No description provided.

@codecov
Copy link

codecovbot commentedAug 15, 2019

Codecov Report

Merging#120 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@          Coverage Diff          @@##           master   #120   +/-   ##=====================================  Coverage     100%   100%           =====================================  Files           1      1             Lines           3      3             Branches        1      1           =====================================  Hits            3      3
Impacted FilesCoverage Δ
src/index.js100% <ø> (ø)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb6b9953...c260b1a. Read thecomment docs.

@VadimKorobka
Copy link
ContributorAuthor

Babel-lodash plugin is not working expected. Please, use lodash modules. I tested it in my project by using webpack-bundle-analyzer.

heartAndRain, igorokb, luismesejo, and chen86860 reacted with thumbs up emojiheartAndRain reacted with hooray emoji

@heartAndRain
Copy link

@JaKXz Can this PR be merged?

MarcLopezAvila, igorokb, huowenxuan, and luismesejo reacted with thumbs up emojiMarcLopezAvila reacted with confused emoji

@MarcLopezAvila
Copy link

Please merge this PR, our bundle size is being affected.

huowenxuan and luismesejo reacted with thumbs up emoji

@VadimKorobka
Copy link
ContributorAuthor

VadimKorobka commentedNov 15, 2019
edited
Loading

Dear@JaKXz,

To make a decision about PR, I propose to consider two aspects:

  1. It is clear to everyone that these changes will not break anything.
  2. This will really reduce the size of the bundle.

Hence, there is no reason to close PR. Even if you think that tree shaking works, then this change simply will not change anything. BUT if it is not true, then we will get a reduced bundle for many projects using this library.We can merge this PR, and make a beta version, which everyone who needs it will try to switch to it, and a little later release a stable.

I am looking forward for your reply.
Faithfully yours, Vadim

@andreieftimie
Copy link

Can we have this or something similar merged in?
This is pulling a complete lodash copy into our bundle.

igorokb, huowenxuan, luismesejo, and chen86860 reacted with thumbs up emoji

@VadimKorobka
Copy link
ContributorAuthor

VadimKorobka commentedJun 21, 2020
edited
Loading

Dear@JaKXz &@timche
We are looking forward to your reply. If it's needed, I can answer the questions.

@VadimKorobka
Copy link
ContributorAuthor

Dear@JaKXz &@timche
We are looking forward to your reply. If it's needed, I can answer the questions.

@timchetimche merged commitf26ab4f intoredux-utilities:masterJul 31, 2021
@timche
Copy link
Member

timche commentedJul 31, 2021
edited
Loading

Thanks for your PR@VadimKorobka! Sorry that it took so long. I'm not actively maintaining this project anymore. I've created a new release (https://github.com/redux-utilities/flux-standard-action/releases/tag/v2.1.2) and published it on npm (https://www.npmjs.com/package/flux-standard-action).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@anmdotdevanmdotdevanmdotdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@VadimKorobka@heartAndRain@MarcLopezAvila@andreieftimie@timche@anmdotdev@koneru1

[8]ページ先頭

©2009-2025 Movatter.jp