- Notifications
You must be signed in to change notification settings - Fork142
Lodash optimization#120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Codecov Report
@@ Coverage Diff @@## master #120 +/- ##===================================== Coverage 100% 100% ===================================== Files 1 1 Lines 3 3 Branches 1 1 ===================================== Hits 3 3
Continue to review full report at Codecov.
|
Babel-lodash plugin is not working expected. Please, use lodash modules. I tested it in my project by using webpack-bundle-analyzer. |
heartAndRain commentedNov 6, 2019
@JaKXz Can this PR be merged? |
MarcLopezAvila commentedNov 14, 2019
Please merge this PR, our bundle size is being affected. |
VadimKorobka commentedNov 15, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Dear@JaKXz, To make a decision about PR, I propose to consider two aspects:
Hence, there is no reason to close PR. Even if you think that tree shaking works, then this change simply will not change anything. BUT if it is not true, then we will get a reduced bundle for many projects using this library.We can merge this PR, and make a beta version, which everyone who needs it will try to switch to it, and a little later release a stable. I am looking forward for your reply. |
andreieftimie commentedDec 11, 2019
Can we have this or something similar merged in? |
VadimKorobka commentedJun 21, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
timche commentedJul 31, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thanks for your PR@VadimKorobka! Sorry that it took so long. I'm not actively maintaining this project anymore. I've created a new release (https://github.com/redux-utilities/flux-standard-action/releases/tag/v2.1.2) and published it on npm (https://www.npmjs.com/package/flux-standard-action). |
No description provided.