Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

perf(size): use lodash modularized packages#115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
alik0211 wants to merge1 commit intoredux-utilities:masterfromalik0211:lodash-modularized
Closed

perf(size): use lodash modularized packages#115

alik0211 wants to merge1 commit intoredux-utilities:masterfromalik0211:lodash-modularized

Conversation

@alik0211
Copy link

Problem: a huge lodash is installed with the package
Solution: use lodash modularized packages

@codecov
Copy link

codecovbot commentedMay 11, 2019•
edited
Loading

Codecov Report

Merging#115 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@          Coverage Diff          @@##           master   #115   +/-   ##=====================================  Coverage     100%   100%           =====================================  Files           1      1             Lines           3      3             Branches        1      1           =====================================  Hits            3      3
Impacted FilesCoverage Δ
src/index.js100% <ø> (ø)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatee3eced3...e612e5f. Read thecomment docs.

@JaKXz
Copy link
Contributor

We usebabel-plugin-lodash, so this is not an issue.

@JaKXzJaKXz closed thisMay 11, 2019
@JaKXz
Copy link
Contributor

JaKXz commentedMay 11, 2019•
edited
Loading

Sorry for the short reply, I'm on my phone rn, please see#51 and the older discussions.

@alik0211
Copy link
Author

@JaKXz This PR has no effect on the size of thelib/index.js.

PR to reduce the size of thenode_modules. Now all lodash is installed:
image

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alik0211@JaKXz
[8]ページ先頭
©2009-2025 Movatter.jp