- Notifications
You must be signed in to change notification settings - Fork142
fix: make meta optional as documented#106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I'm providing with pull request a little example how it can be used with action creators. Because in current implementation action creator must return 'meta' explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
jack-guy commentedMar 24, 2018
I think this should get merged! Clearly with the number of times this has come up, TypeScript users are generally confused that the type definitions do not match the documentation. If a property is truly optional, like {type:'foo',meta:null,} Incidentally, DefinitelyTypedhas always had this right. By the way, we should technically be doing the same for payload as well... |
npoirey commentedApr 6, 2018
I agree, we should merge this and do the same for payload |
Sorry for the delay in getting this merged! I will have a patch released with teh fix for payload as well today. |
|
I'm providing with pull request a little example how it can be used with action creators. Because in current implementation action creator must return 'meta' explicit.
Link to Typescript playground