- Notifications
You must be signed in to change notification settings - Fork121
Added 2021 and 2022 data with aanalysis and updated streamlit app#316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Co-authored-by: Nikita Nikitababb036@gmail.comCo-authored-by: Leena leenagoyal2403@gmail.com
sanjay-kv left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome@NIKITA320495
some suggestions for you would be : adding description on the changes made in the PR.
incoperating bit more coding comments. so it will improve readbility and understanding for future developments.
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
sanjay-kv commentedJul 4, 2024
Could you check and reply here regarding the Streamlit app and Streamlit on Snowflakes are same thing?@NIKITA320495 |
Leena2403 commentedJul 8, 2024
hello@sanjay-kv sir, please assign me the PR as well. As Nikita and I collaborated on this one as well. And yes, we'll make sure to add proper comments for readability from now on. As for Snowflakes, we never worked on it, so not sure. |
sanjay-kv commentedJul 8, 2024
leena just raise one more PR and link the PR to there. and I will assign same level. it has been noted leaderboard is not fetching two people on co-authored commits.
|
Leena2403 commentedJul 9, 2024
Ok@sanjay-kv sir ! |
This is a sample PR for the issuerecodehive#316 (recodehive#316) that I collaborated on.Due to some technical issues, my PR couldn't be merged, hence a sample merge is being created for fetching updated information on leaderboard.
No description provided.