Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.8k
Feature/tooltip closing#6007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
JoaquinPalacios wants to merge23 commits intorecharts:mainChoose a base branch fromJoaquinPalacios:feature/tooltip-closing
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Changes from1 commit
Commits
Show all changes
23 commits Select commitHold shift + click to select a range
75cce49
feat: tooltip closing
JoaquinPalacioscaea900
All tests passed
JoaquinPalacios992dc28
Remove log
JoaquinPalacios5215d46
Tooltip state test updated
JoaquinPalaciose14dee0
test for mouseEventsMidleware added
JoaquinPalacios27b1896
tests for mouseEventsMidleware updated
JoaquinPalacios8b944dc
Treemap Bar and Funnel tests udpated
JoaquinPalacios877e999
refactor: remove redundant event handling logic from chart components
JoaquinPalaciosc23f302
Update RechartsWrapper.tsx
JoaquinPalacios35036e2
consolidate event handler logic with createEventHandlers utility
JoaquinPalacios35c6b11
Merge remote-tracking branch 'upstream/main' into feature/tooltip-clo…
JoaquinPalaciosc6d6244
Update tooltipSlice.ts
JoaquinPalacios5b5258a
fix: replace timeout-based tooltip closing with event-driven approach
JoaquinPalacios3787ce4
refactor: simplify tooltip close handling by removing onRequestToolti…
JoaquinPalaciose5aa4b6
Fix: Remove isClosing state and simplify tooltip closing mechanism
JoaquinPalacios00c69d8
Update Treemap.spec.tsx
JoaquinPalacios8aafe58
Update RechartsWrapper.tsx
JoaquinPalaciosd80d13d
Refactor event handlers to use centralized noop defaults
JoaquinPalacios351afd2
Update Bar.tsx
JoaquinPalaciose7c3906
Update Treemap.tsx
JoaquinPalaciosbbcc682
Update Pie.tsx
JoaquinPalacios1969150
Correct tooltip positioning in FunnelChart
JoaquinPalaciosfd439be
Simplify tests for mouseClickMiddleware
JoaquinPalaciosFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Update Pie.tsx
Remove redundant event handler props
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitbbcc682e20e1b08cf696543e42548dc71b2217ee
There are no files selected for viewing
3 changes: 0 additions & 3 deletionssrc/polar/Pie.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.