Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add keyPath initializer for Persisted<LinkingObjects>#8136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
jsflax wants to merge3 commits intomaster
base:master
Choose a base branch
Loading
fromjf/originKeyPath

Conversation

@jsflax
Copy link
Contributor

No description provided.

@cla-bot
Copy link

cla-botbot commentedFeb 16, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors:Jason Flax.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commitsgit config --list | grep email
  2. If not, set it up usinggit config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, seehttps://github.com/settings/emails

@leemaguire
Copy link
Contributor

needs a changelog entry

publicinit(originProperty:String){
self.init(wrappedValue:Value(fromType:Value.Element.self, property: originProperty))
}
publicinit<V>(originProperty:KeyPath<Value.Element,V>)where Value.Element:ObjectBase{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This'll allow specifying any type of property as the origin property and ideally it'd be constrained to links.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done.

@cla-bot
Copy link

cla-botbot commentedFeb 16, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors:Jason Flax.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commitsgit config --list | grep email
  2. If not, set it up usinggit config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, seehttps://github.com/settings/emails

@jsflaxjsflax requested a review fromtgoyneFebruary 16, 2023 18:36
Copy link
Contributor

@dianaafanador3dianaafanador3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Our test doesn't seem to like the use of this
EXC_BAD_ACCESS (code=2, address=0x16f603bb8).

@jsflaxjsflax marked this pull request as draftMay 9, 2023 15:11
@tgoynetgoyne removed their request for reviewMay 22, 2023 23:53
@leemaguireleemaguire removed their request for reviewAugust 16, 2024 09:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tgoynetgoynetgoyne left review comments

+1 more reviewer

@dianaafanador3dianaafanador3dianaafanador3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jsflaxjsflax

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jsflax@leemaguire@tgoyne@dianaafanador3

[8]ページ先頭

©2009-2025 Movatter.jp