Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Schema setsminProperties=1 forbuild.tools, but an empty object is allowed by the service #12592

Open
@sirosen

Description

@sirosen

Details

Inpip-tools, our RTD config setsbuild.tools: {}. (ref)
I can't recallwhy -- it wasn't something we discussed with the new config -- maybe I thought it was more explicit? I think just omittingtools would be equivalent, but I don't feel 100% certain of that?

When we went to add schema validation to our lints (check-jsonschema inpre-commit), we were surprised to see it fail.
The failure is caused by"minProperties": 1 beingset here on the schema forbuild.tools.

I'd like to update and relax the schema, allowing the empty object, on the grounds that it is allowed by RTD when loading config and executing a build.

Expected Result

The config, which works, should pass validation against the RTD schema.

Actual Result

The schema and service are in disagreement, and the working config fails validation.


I intend to open a PR for this momentarily. If the change is unacceptable for some reason (e.g., RTD is trying to migrate to require this), but I can get confirmation that omittingbuild.tools is equivalent to specifying it as empty, that would be helpful as an alternative.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp