Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork131
Update to require PHP 7.1+#276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Update to require PHP 7.1+#276
Uh oh!
There was an error while loading.Please reload this page.
Conversation
8dfab30 toa6bc754Compared62cd4e toec578d4Compareeee05cc to1321766CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@WyriHaximus Went over your changes together with@cassifyit and addressed all outstanding issues, great work, now let's get this shipped!
For the reference: Link to diff between originaleee05cc and new1321766:https://gist.github.com/clue/98910c5ec0c390225d702d897e366304)
1321766 tocde4017CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull request looks good to me, let's get this in 👍
Uh oh!
There was an error while loading.Please reload this page.
This changeset updates the project to require PHP 7.1+ and drop legacy PHP < 7.1 and HHVM as discussed in#271. I'm marking this as a BC break for anybody still stuck on very old PHP versions, but there's little chance this will affect any current projects otherwise.
This PR aims to contain the minimal changeset to update the PHP version requirement only. Follow-up PRs will update our APIs to leverage newer language features.
Builds on top of#269,#272,#273 and others
Refsreactphp/cache#58 andreactphp/stream#175