Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

UseReactDOM.createRoot instead ofReactDOM.render#238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
ZeroIntensity wants to merge6 commits intoreactive-python:main
base:main
Choose a base branch
Loading
fromZeroIntensity:patch-1

Conversation

ZeroIntensity
Copy link

Description

ReactDOM.render is deprecated as of React 18 (seehere), and removed in React 19 (seehere). This switches to the alternative,ReactDOM.createRoot(...).render(<Root />).

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@ZeroIntensityZeroIntensity requested a review froma team as acode ownerJune 2, 2024 18:42
@Archmonger
Copy link
Contributor

Looks like this change broke the testing suite.

Maybe the ReactJS version needs to be bumped to support this?

@ZeroIntensity
Copy link
Author

Could be, but looking at the package lock, it seems to be in React 17, so it should support this. I'm not sure how the testing suite it set up, butcreateRoot supposedly takes control of the DOM node somehow. Perhaps that's screwing things up?

@ZeroIntensity
Copy link
Author

Scratch that -createRoot was added in React 18, not 17, so yeah, it's the version.

@ArchmongerArchmonger marked this pull request as draftNovember 25, 2024 04:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ZeroIntensity@Archmonger
[8]ページ先頭
©2009-2025 Movatter.jp