Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add pageSheet presentation to native stack, bump react-native-screens to 4.11.1#12503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
kligarski wants to merge2 commits intoreact-navigation:main
base:main
Choose a base branch
Loading
fromkligarski:@kligarski/add-support-for-page-sheet

Conversation

kligarski
Copy link
Contributor

@kligarskikligarski commentedMar 21, 2025•
edited
Loading

Motivation

Since the release of iOS 18, screens withpresentation: 'modal' changed size on devices with a bigger screen, such as an iPad - they became much smaller, which impacted applications of the library's users (see issuesoftware-mansion/react-native-screens#2549).

To address the issue,react-native-screens will introduce new presentation type for native stack (pageSheet) that will allow users to use previous modal behavior (see PRsoftware-mansion/react-native-screens#2793). The behavior ofpageSheet on Android will be the same asmodal.

This PR contains changes required to supportpageSheet inreact-navigation. It also bumpsreact-native-screens version to4.11.1.

Test plan

Open Stack Presentation and Modals example screens in example apps fromreact-native-screens and open apageSheet.

@kligarski
Copy link
ContributorAuthor

@kkafar

@netlifyNetlify
Copy link

netlifybot commentedMar 21, 2025•
edited
Loading

✅ Deploy Preview forreact-navigation-example ready!

NameLink
🔨 Latest commit60e5dce
🔍 Latest deploy loghttps://app.netlify.com/projects/react-navigation-example/deploys/6842c370a3b95b0008c72a42
😎 Deploy Previewhttps://deploy-preview-12503--react-navigation-example.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify project configuration.

@Gregoirevda
Copy link

What's the status on this?

@kkafar
Copy link
Contributor

I do not remember whether I've just forgot to review this one, or was it blocked@kligarski?

@kkafarkkafar self-requested a reviewMay 9, 2025 12:15
@kligarski
Copy link
ContributorAuthor

@kkafar It's ready but I think we need to bumpreact-native-screens version in order to fix TS warnings.pageSheet was added toreact-native-screens inthis release but 4.11.0 is still in beta - I guess that we want to wait for stable release.

@kligarskikligarskiforce-pushed the@kligarski/add-support-for-page-sheet branch frombabf706 to60e5dceCompareJune 6, 2025 10:31
@kligarskikligarski changed the titlefeat: add pageSheet presentation to native stackfeat: add pageSheet presentation to native stack, bump react-native-screens to 4.11.1Jun 6, 2025
@kligarski
Copy link
ContributorAuthor

@kkafar

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kkafarkkafarAwaiting requested review from kkafar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kligarski@Gregoirevda@kkafar
[8]ページ先頭
©2009-2025 Movatter.jp