Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.1k
chore: configure maestro tests on CI for iOS & Android#12341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
125c866 to4c21b5aCompare✅ Deploy Preview forreact-navigation-example ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
The Expo app for the example from this branch is ready! |
4c21b5a to1a2b83eCompare✅ Deploy Preview forreact-navigation-example ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
1a2b83e to06b7565Compare✅ Deploy Preview forreact-navigation-example ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
netlifybot commentedDec 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview forreact-navigation-example ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
e4adcea to28acad5Compare4a53d24 to711a945Comparecodecov-commenter commentedDec 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install theCodecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@## main #12341 +/- ##==========================================+ Coverage 76.91% 76.93% +0.01%========================================== Files 220 220 Lines 6883 6897 +14 Branches 2796 2804 +8 ==========================================+ Hits 5294 5306 +12- Misses 1524 1526 +2 Partials 65 65 ☔ View full report in Codecov by Sentry. |
c3e174c to9dd09ffCompare9dd09ff toc28763eCompareHey@szymonrybczak! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read ourcontribution guidelines. |
7616214 to7eed252Compareszymonrybczak commentedJan 29, 2025
So to give an update here, tests are executing on CI for Android & iOS & Web. Native tests are failing because of actual tests (as of testing they're failing locally too). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR configures Maestro tests on CI for iOS and Android by updating the test YAML files and adding new GitHub workflows.
- Updated test YAML files by inserting a clearState step and updating deep link URLs
- Renamed and added new workflows for Expo publish/preview, E2E web, iOS, and Android testing
- Removed a redundant e2e-test job from the CI workflow
Reviewed Changes
Copilot reviewed 35 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| example/e2e/maestro/*.yml | Added a clearState step and updated openLink URLs to use APP_SCHEME |
| .github/workflows/expo-publish.yml | Renamed workflow from "Expo Publish" to "Expo" |
| .github/workflows/expo-preview.yml | Renamed workflow from "Expo Preview" to "Expo" |
| .github/workflows/e2e-web.yml | Added workflow to run end-to-end web tests |
| .github/workflows/e2e-ios.yml | Added workflow for iOS Maestro tests |
| .github/workflows/e2e-android.yml | Added workflow for Android Maestro tests |
| .github/workflows/ci.yml | Removed an outdated e2e-test job |
Files not reviewed (1)
- example/app.json: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/expo-publish.yml:1
- [nitpick] The workflow name 'Expo' might be too generic after removing the 'Publish' suffix. Consider reverting to a more descriptive name (e.g., 'Expo Publish') to clearly indicate its purpose.
+name: Expo.github/workflows/expo-preview.yml:1
- [nitpick] Using the name 'Expo' for the preview workflow could be ambiguous. A name such as 'Expo Preview' would better differentiate its intent from other Expo workflows.
+name: ExpoThe Expo app for the example from this branch is ready! |
No description provided.