Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.1k
fix(native-stack, v6): incorrect text truncation in header title#12135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
kkafar wants to merge6 commits into6.xChoose a base branch
base:6.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
✅ Deploy Preview forreact-navigation-example ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
Hey@autofix-ci[bot]! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read ourcontribution guidelines. |
The Expo app for the example from this branch is ready! |
1804791 to98dcf3bComparekkafar added a commit to software-mansion/react-native-screens that referenced this pull requestSep 13, 2024
in this commit react-navigation is on v6 branch.You need to change it back to v7 and apply changes to the v7 branch.This is the reference PR to v6:react-navigation/react-navigation#12135
satya164 pushed a commit that referenced this pull requestOct 7, 2024
…id (#12125)**Motivation**Together with corresponding PR in `react-native-screens`:*software-mansion/react-native-screens#2325this PRfixessoftware-mansion/react-native-screens#1946tldr: text truncation in header title should work properly from now on. This PR changes the layout model of the native-header. Previously Yogahas been informed that the children are positioned absolutely and itsonly responsibility was to determine the view sizes. Right now, on Yogalayer (but not in native layer) the header is laid out with flexboxmodel.**Test plan**I've conducted the tests manually on `TestHeaderTitle` test screen in`FabricExample` application in `react-native-screens` repository.Below is the spreadsheet from these tests.Corresponding v6 PR:*#12135---------Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wip WIP