Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.1k
feat(iOS,v6): support for form sheet medium detent#11516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:6.x
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The Expo app for the example from this branch is ready! |
The question is: "do I have to?"Should I bump screens version in `native-stack`, all packages or justuse `@tsignore`? Or maybe there is other mechanism of handling suchsituations in use.
codecov-commenter commentedAug 1, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install theCodecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@## 6.x #11516 +/- ##======================================= Coverage 74.19% 74.19% ======================================= Files 178 178 Lines 5623 5623 Branches 2216 2216 ======================================= Hits 4172 4172 Misses 1402 1402 Partials 49 49 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
hadnet commentedAug 24, 2023
Is this feature gonna be available only in v7? |
I aim to introduce it to v5, v6 and v7, however progress on this PR depends onsoftware-mansion/react-native-screens#1852 which in turn waits for progress in Android modal implementation so I can create somewhat consistent API between two platforms. |
Converted the PR to draft so it's easier to notice that it's wip. Please mark as ready once done. |
## Description This PR introduces support for `formSheet` presentation on Android andbrings support for custom detents on iOS.I've ensured that this PR is backward compatible, i. g. I've broughtback support for `medium`, `large` and `all` options, which weresupposed to be dropped.Please note this this changes will work with react-native-screens 4.0.0onwards.There is plan to land this feature on v6 line (will requirereact-native-screens 3.35.0 or 3.36.0 or newer), however it is deferredfor now.Associated PR:*#11516## DisclaimersThe extended functionalities of `formSheet` stack presentation do comewith its limitations.* Android supports only up to three possible detent values. * `fitToContents` detent level can not be yet passed together with othervalues (this is work in progress and if sensible API is feasible we'llrelease it later).* there are limitations on flex layout inside the sheet's content oniOS. To mitigate other, more staggering issues, we do not notify React'slayout system on sheet height's changes. This causes e.g. to causeissues when trying to center elements vertically depending on currentsheet height. If that's your use case - form sheet is not eligible yet.If you happen to notice any issue related to the formsheet API considerforwarding it to the [`react-native-screens`repository](https://github.com/software-mansion/react-native-screens).Thanks!**Test plan**Since this change involves native-stack solely I've tested this onExample & FabricExample apps in [`react-native-screens`repository](https://github.com/software-mansion/react-native-screens/tree/main/Example)(e.g. `Test1649` can be used).---------Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Motivation
WIP WIP
TODO:
react-native-screens
to3.23.0
across repoIf this pull request addresses an existing issue, link to the issue. If an issue is not present, describe the issue here.
Test plan
WIP WIP
The change must pass lint, typescript and tests.