Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(Tab): indicator width calculations#3807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
arpitBhalla wants to merge6 commits intoreact-native-elements:next
base:next
Choose a base branch
Loading
fromarpitBhalla:rne-tab

Conversation

arpitBhalla
Copy link
Member

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked withexample app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation usingyarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@netlify
Copy link

netlifybot commentedJun 18, 2023
edited
Loading

Deploy Preview forreact-native-elements ready!

NameLink
🔨 Latest commit1a3c441
🔍 Latest deploy loghttps://app.netlify.com/sites/react-native-elements/deploys/64a5999f0e21150008a3675a
😎 Deploy Previewhttps://deploy-preview-3807--react-native-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify site configuration.

Edgarruiz85 reacted with heart emoji

@codecov
Copy link

codecovbot commentedJun 18, 2023
edited
Loading

Codecov Report

Merging#3807 (396845b) intonext (6ea6a97) willincrease coverage by0.62%.
The diff coverage is83.78%.

❗ Current head396845b differs from pull request most recent head1a3c441. Consider uploading reports for the commit1a3c441 to get more accurate results

@@            Coverage Diff             @@##             next    #3807      +/-   ##==========================================+ Coverage   79.39%   80.02%   +0.62%==========================================  Files          87       87                Lines        1820     1822       +2       Branches      810      811       +1     ==========================================+ Hits         1445     1458      +13+ Misses        370      359      -11  Partials        5        5
Impacted FilesCoverage Δ
packages/base/src/Avatar/index.tsx100.00% <ø> (ø)
packages/base/src/Tab/Tab.Item.tsx95.45% <ø> (ø)
packages/base/src/Tab/Tab.tsx64.51% <53.84%> (+4.19%)⬆️
packages/base/src/Avatar/Avatar.tsx100.00% <100.00%> (+2.77%)⬆️
...ages/base/src/CheckBox/components/CheckBoxIcon.tsx100.00% <100.00%> (ø)
packages/base/src/Divider/Divider.tsx92.30% <100.00%> (ø)
packages/base/src/Header/Header.tsx96.55% <100.00%> (+0.39%)⬆️
packages/base/src/Icon/Icon.tsx100.00% <100.00%> (ø)
packages/base/src/Input/Input.tsx66.66% <100.00%> (+0.87%)⬆️
packages/themed/src/config/ThemeProvider.tsx76.59% <100.00%> (+12.76%)⬆️

... and1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times.Learn more

Edgarruiz85 reacted with heart emojiEdgarruiz85 reacted with rocket emoji

@mkozmelj
Copy link

Any progress on this MR?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabs crash app with error "RCTView",{"transform":[{"translateX":"<<NaN>>"}]}] is not usable as a native method argument
2 participants
@arpitBhalla@mkozmelj

[8]ページ先頭

©2009-2025 Movatter.jp