Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add@rneui/layout#3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
arpitBhalla wants to merge20 commits intoreact-native-elements:next
base:next
Choose a base branch
Loading
fromarpitBhalla:pkg-layout

Conversation

arpitBhalla
Copy link
Member

@arpitBhallaarpitBhalla commentedOct 1, 2022
edited
Loading

Edgarruiz85 reacted with heart emoji
@bartvanandel
Copy link

We've been using that package in a WIP app, but we switched to a custom View component instead after running into too many issues with this package. I haven't kept a list unfortunately, but we did find that changing styling of a parent component could cause items to disappear from the screen when using<Stack /> for instance. I wouldn't consider this production ready (hence the alpha in the version, presumably).

One reason for adding this package though would be that some of the examples rely on it, and don't actually work without it currently.

Edgarruiz85 reacted with heart emoji

@arpitBhallaarpitBhalla marked this pull request as draftOctober 3, 2022 13:20
@codecov
Copy link

codecovbot commentedOct 28, 2022
edited
Loading

Codecov Report

Merging#3648 (20b4243) intonext (f5f5812) willdecrease coverage by0.57%.
The diff coverage is57.44%.

❗ Current head20b4243 differs from pull request most recent headab9dfb7. Consider uploading reports for the commitab9dfb7 to get more accurate results

@@            Coverage Diff             @@##             next    #3648      +/-   ##==========================================- Coverage   79.42%   78.85%   -0.58%==========================================  Files          87       93       +6       Lines        1823     1868      +45       Branches      806      836      +30     ==========================================+ Hits         1448     1473      +25- Misses        370      390      +20  Partials        5        5
Impacted FilesCoverage Δ
packages/layout/src/Grid/Grid.tsx0.00% <0.00%> (ø)
packages/layout/src/Grid/GridItem.tsx0.00% <0.00%> (ø)
packages/layout/src/Grid/index.tsx0.00% <0.00%> (ø)
packages/layout/src/Stack/index.tsx0.00% <0.00%> (ø)
packages/layout/src/Box/index.tsx100.00% <100.00%> (ø)
packages/layout/src/system/makeStyles.ts100.00% <100.00%> (ø)
packages/base/src/Tab/Tab.tsx57.14% <0.00%> (-3.18%)⬇️
packages/base/src/Avatar/Avatar.tsx97.22% <0.00%> (ø)
packages/base/src/Button/Button.tsx90.66% <0.00%> (ø)
packages/base/src/Switch/Switch.tsx100.00% <0.00%> (ø)
... and5 more

📣 We’re building smart automated test selection to slash your CI/CD build times.Learn more

Edgarruiz85 reacted with heart emoji

@arpitBhalla
Copy link
MemberAuthor

Hey@bartvanandel, I just release another alpha for this pkg, would it be possible for you to testStack andBox component?

Edgarruiz85 reacted with heart emoji

@arpitBhallaarpitBhalla linked an issueApr 11, 2023 that may beclosed by this pull request
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pranshuchittorapranshuchittoraAwaiting requested review from pranshuchittora

@khushal87khushal87Awaiting requested review from khushal87

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack Component in Documentation
2 participants
@arpitBhalla@bartvanandel

[8]ページ先頭

©2009-2025 Movatter.jp