Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

🔬 feat: exp with react-compiler (#12309)#12333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
bluebill1049 wants to merge26 commits intomaster
base:master
Choose a base branch
Loading
fromreact-complier

Conversation

bluebill1049
Copy link
Member

@bluebill1049bluebill1049 commentedOct 12, 2024•
edited
Loading

related#12298

API

  • getFieldState
  • reset
  • register
  • getValues
  • watch

rodrigofariow, RobinClowers, arusahni, yslpn, WiXSL, Nedomas, yanghuilong, ellemedit, aykxt, hubert-itsharkz, and 6 more reacted with heart emoji
* test: Add task running unit tests with react-compiler* Use official compiler runtime* 📖 fix: code example input field placeholder name (#12296)* 🐞fix:#12294 ensure Invalid Date is evaluated correctly (#12295)* fix: ensure Invalid Date is evaluated correctly*fix:#12294 ensure Invalid Date is evaluated correctly*fix:#12294 ensure Invalid Date is evaluated correctly* Update createFormControl.ts* Update createFormControl.ts* Update createFormControl.ts---------Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>---------Co-authored-by: Kim Sang Du <puki4416@gmail.com>Co-authored-by: Toshiki Saito <50011163+crypt0box@users.noreply.github.com>Co-authored-by: Beier (Bill) <bluebill1049@hotmail.com>
@bluebill1049bluebill1049 marked this pull request as draftOctober 12, 2024 22:18
@github-actionsGitHub Actions
Copy link
Contributor

github-actionsbot commentedOct 13, 2024•
edited
Loading

Size Change: +279 B (+0.51%)

Total Size: 55.2 kB

FilenameSizeChange
dist/index.cjs.js11 kB+81 B (+0.74%)
dist/index.esm.mjs20.3 kB+113 B (+0.56%)
dist/index.umd.js11.1 kB+85 B (+0.77%)
ℹ️View Unchanged
FilenameSize
dist/react-server.esm.mjs12.8 kB

compressed-size-action

@bluebill1049bluebill1049 changed the titletest: Add task running unit tests with react-compiler (#12309)feat: exp with react-compiler (#12309)Oct 19, 2024
@ellemedit
Copy link

could I know what's blocking this?

aykxt, jnelle, yslpn, and RohovDmytro reacted with thumbs up emoji

@bluebill1049
Copy link
MemberAuthor

could I know what's blocking this?

I will need more time to get to it and then release an RC version of it later.

aykxt, jnelle, ellemedit, yslpn, ImLunaHey, and RohovDmytro reacted with thumbs up emoji

@staleStale
Copy link

stalebot commentedMay 6, 2025

Thank you for your contributions! This Pull Request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Best, RHF Team ❤️

yslpn, agos, Kavan72, dim-vendorful, ImLunaHey, mondaychen, ybelakov, and RohovDmytro reacted with confused emojiyslpn, Kavan72, ImLunaHey, and RohovDmytro reacted with eyes emoji

@stalestalebot added the stale labelMay 6, 2025
@ybelakov

This comment was marked as spam.

@bluebill1049bluebill1049 changed the titlefeat: exp with react-compiler (#12309)🔬 feat: exp with react-compiler (#12309)Jun 9, 2025
Copy link

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR introduces experimental support for the react-compiler along with several improvements to form-related tests and component definitions. The main changes include:

  • Updates to test components with explicit prop type definitions.
  • Replacing JSON-stringified output assertions with direct text checks.
  • Renaming of temporary ID variables from "i" to "mockId" throughout field array tests.
  • New Babel and Jest configuration to support the react-compiler.

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.

Show a summary per file
FileDescription
src/tests/useForm/reset.test.tsxChanged assertions from JSON-stringified outputs to conditional text rendering.
src/tests/useForm/handleSubmit.test.tsxAdded explicit prop types for test component and updated render calls.
src/tests/useForm/getFieldState.test.tsxRemoved unused destructured properties in tests.
src/tests/useForm/formState.test.tsxModified waitFor usage and added explicit text rendering.
src/tests/useFieldArray/*Renamed temporary ID variable from "i" to "mockId" in multiple tests.
src/tests/useController.test.tsxUpdated component definitions with explicit prop types.
src/tests/form.test.tsxRefactored test components to pass explicit props.
src/tests/controller.test.tsxUpdated tests to use explicit prop types and adjusted assertions.
scripts/jest/jest-react-compiler.config.jsIntroduced a new Jest config for react-compiler.
package.jsonAdded a new test command and Babel dependencies for react-compiler support.
babel.config.jsConfigured Babel to enable react-compiler plugin for test files.
app/src/setValue.tsxAdjusted useEffect dependencies for setting form values.
Comments suppressed due to low confidence (1)

app/src/setValue.tsx:63

  • [nitpick] Removing 'register' from the dependency array may be acceptable if it is stable. Please verify that its exclusion does not affect the intended registration behavior.
  }, [setValue]);

@Maxou44

This comment was marked as spam.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@bluebill1049@ellemedit@ybelakov@Maxou44@stevoland
[8]ページ先頭
©2009-2025 Movatter.jp