Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: configurable entrypoint for kubernetes pod executor#740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
deryrahman merged 8 commits intomainfromconfig-sourcing-on-executor-container
Feb 24, 2023

Conversation

@deryrahman
Copy link
Member

@deryrahmanderyrahman commentedFeb 13, 2023•
edited
Loading

  • entrypoint to print the plugin configs
  • patch for plugin validation

@deryrahmanderyrahmanforce-pushed theconfig-sourcing-on-executor-container branch fromf98c18e to540c69bCompareFebruary 14, 2023 07:18
@coveralls
Copy link

coveralls commentedFeb 14, 2023•
edited
Loading

Pull Request Test Coverage Report forBuild 4249249625

  • 9 of9(100.0%) changed or added relevant lines in3 files are covered.
  • 10 unchanged lines in1 file lost coverage.
  • Overall coverage increased (+0.09%) to92.12%
Files with Coverage ReductionNew Missed Lines%
core/scheduler/service/job_run_service.go1093.91%
TotalsCoverage Status
Change from baseBuild 4141290951:0.09%
Covered Lines:8370
Relevant Lines:9086
💛 -Coveralls

Copy link
Member

@smarchonesmarchone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@deryrahmanderyrahman merged commite96ca18 intomainFeb 24, 2023
@deryrahmanderyrahman deleted the config-sourcing-on-executor-container branchFebruary 24, 2023 03:43
sravankorumilli pushed a commit that referenced this pull requestFeb 27, 2023
* feat: add entrypoint feature on plugins* remove: fetch env and secret from api* feat: return info with entrypoint* remove: unecessary param on dag template* test: fix test* refactor: use get entrypoint func* feat: make entrypoint as required* feat: validate plugin yaml info
@smarchonesmarchone changed the titlefeat: configurable endpoint for kubernetes pod executorfeat: configurable entrypoint for kubernetes pod executorFeb 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@smarchonesmarchonesmarchone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deryrahman@coveralls@smarchone
[8]ページ先頭
©2009-2025 Movatter.jp