Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[core][cgraph] Refactor get_devices() for compiled graph#51855

Open
ruisearch42 wants to merge2 commits intoray-project:master
base:master
Choose a base branch
Loading
fromruisearch42:cgraph_devices

Conversation

ruisearch42
Copy link
Contributor

@ruisearch42ruisearch42 commentedMar 31, 2025
edited
Loading

Why are these changes needed?

This is a follow up for#51734

The reason#51305 caused illegal GPU memory access in vLLM is that it assumesCUDA_VISIBLE_DEVICES for an actor is limited to a single GPU ID, and the worker can always accesses the GPU withcuda:0. While this is a reasonable assumption for Ray backed applications in general, it is not the case for vLLM. Historically vLLM altersCUDA_VISIBLE_DEVICES and sets it to the list of local GPUs (on the same node) for maintaining distributed groups for both the Ray and MP backends. While this could be cleaned up, it will be a longer-term process.

This PR refactors and cleans up the utils.get_devices() API.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e.,git commit -s) in this PR.
  • I've runscripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed forhttps://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it indoc/source/tune/api/ under the
      corresponding.rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures athttps://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
Signed-off-by: Rui Qiao <ruisearch42@gmail.com>
@ruisearch42ruisearch42 added the goadd ONLY when ready to merge, run all tests labelApr 1, 2025
Copy link
Collaborator

@edoakesedoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

suggest to add unit tests for this function

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@edoakesedoakesedoakes left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
goadd ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ruisearch42@edoakes

[8]ページ先頭

©2009-2025 Movatter.jp